-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle SIGTERM and signals from user space #57
Conversation
This reverts commit 7ab8ab3.
Co-authored-by: Jon Gjengset <[email protected]>
Co-authored-by: Jon Gjengset <[email protected]>
Co-authored-by: Jon Gjengset <[email protected]>
@jonhoo I think all the threads have been addressed. I thing that I have just realized is that we do not allow to Imagine the situation where the server told us to stop the consumption (we get this message in the heartbeat task on the coordinator), and we do so and mark the coordinator as terminated. What they can do then is take this worker and call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it's a good point. I think I agree that run_one
also shouldn't be possible once terminated 👍
Co-authored-by: Jon Gjengset <[email protected]>
Co-authored-by: Jon Gjengset <[email protected]>
Co-authored-by: Jon Gjengset <[email protected]>
As per #4
This change is